This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
Add password as command line argument #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gregwebs
reviewed
Dec 16, 2019
| @@ -222,6 +222,7 @@ func (cfg *Config) LoadFromGlobal(global *GlobalConfig) error { | |||
| cfg.TiDB.Host = global.TiDB.Host | |||
| cfg.TiDB.Port = global.TiDB.Port | |||
| cfg.TiDB.User = global.TiDB.User | |||
| cfg.TiDB.Psw = global.TiDB.Psw | |||
There was a problem hiding this comment.
I am more familiar with "Pwd" as an abbreviation, but do we need to abbreviate this at all?
There was a problem hiding this comment.
I used Psw to mimic the field name in the config
There was a problem hiding this comment.
What did you mean by "mimic the field name in the config"? There is no Psw field in the configuration file.
There was a problem hiding this comment.
The field can be named "Psw" for consistency with old code (or all renamed to "Password"), but the CLI argument should be named -tidb-password not -tidb-psw.
|
/run-all-tests |
kennytm
added
status/LGT1
gregwebs
approved these changes
Dec 17, 2019
|
pingcap/docs#1711 PR for updating docs |
kennytm
removed
the
Should Update Docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Previously it is not possible to supply the user password by command line, unlike other restore tools like
loaderWhat is changed and how it works?
Adds
-tidb-passwordcommand line optionCheck List
Tests
Side effects
Related changes
tidb-ansiblerepository